📝 Docs preview for commit d83f792 at: https://62d04b8528f3e0240fbc7885--typertiangolo.netlify.app

Codecov Report

Attention: Patch coverage is 43.75000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 99.69%. Comparing base (1e43c6b) to head (d83f792).
Report is 237 commits behind head on master.

❗ Current head d83f792 differs from pull request most recent head a771189

Please upload reports for the commit a771189 to get more accurate results.

@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
+ Coverage   96.24%   99.69%   +3.44%     
==========================================
  Files         280      286       +6     
  Lines        5942     6456     +514     
==========================================
+ Hits         5719     6436     +717     
+ Misses        223       20     -203     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

📝 Docs preview for commit 7a3466d at: https://639cea33a12b8e0af09de2a5--typertiangolo.netlify.app

📝 Docs preview for commit 1e261e6 at: https://63a3728fbc88656dcfeedf1c--typertiangolo.netlify.app

Any updates on merging this? @tiangolo

Upvote for this PR, as using Literal is more succinct then using enum.

📝 Docs preview for commit d4cd3c3 at: https://6e1d3ac2.typertiangolo.pages.dev

📝 Docs preview for commit c7dd353 at: https://89793d8d.typertiangolo.pages.dev

📝 Docs preview for commit 6065329 at: https://85835217.typertiangolo.pages.dev

📝 Docs preview for commit 3b9034b at: https://a0405a66.typertiangolo.pages.dev

Preview of new docs section: https://a0405a66.typertiangolo.pages.dev/tutorial/parameter-types/enum/#literal-choices

Thanks for this PR @blackary! I've taken the liberty to update this PR with the latest from master. I also added some improvements using new functionality from _typing.py, taking inspiration from the similar PR #669. This PR and that one now both cover largely the same functionality. I would personally merge this one and close the other, but will leave the final decision with Tiangolo as usual 😇

Thanks @svlandeg!

📝 Docs preview for commit a771189 at: https://4a31fc21.typertiangolo.pages.dev

Gently ping @tiangolo

Hi all,

There's no need for pinging individual maintainers - this PR is on our internal board and will be reviewed further when Tiangolo has time. All the additional pings make our Github notifications difficult to use and only costs more time 😉 Thanks for your patience!

📝 Docs preview for commit 74a6116 at: https://ffe72ce6.typertiangolo.pages.dev

Modified Pages

• https://ffe72ce6.typertiangolo.pages.dev/tutorial/parameter-types/enum/

📝 Docs preview for commit c29c5d2 at: https://c23a0dec.typertiangolo.pages.dev

Modified Pages

• https://c23a0dec.typertiangolo.pages.dev/tutorial/parameter-types/enum/

📝 Docs preview for commit cb93aa4 at: https://2f6cbaf9.typertiangolo.pages.dev

Modified Pages

• https://2f6cbaf9.typertiangolo.pages.dev/tutorial/parameter-types/enum/

📝 Docs preview for commit 1834fb8 at: https://9dfe14ad.typertiangolo.pages.dev

Modified Pages

• https://9dfe14ad.typertiangolo.pages.dev/tutorial/parameter-types/enum/

📝 Docs preview for commit f06dcf5 at: https://1c296473.typertiangolo.pages.dev

Modified Pages

• https://1c296473.typertiangolo.pages.dev/tutorial/parameter-types/enum/

Currently, the CI is failing with

Run ls -la coverage
ls: cannot access 'coverage': No such file or directory
Error: Process completed with exit code 2.

I'm pretty confused why this happens here though 🤔

Update: this looks to be an issue separate from this PR - we're looking into it!

Update 2: this should be fixed by #967

📝 Docs preview for commit 20b55f6 at: https://43e3b3f1.typertiangolo.pages.dev

Modified Pages

• https://43e3b3f1.typertiangolo.pages.dev/tutorial/parameter-types/enum/

Sorry to bother. I wonder what's the status of this PR?